Avoid repeatedly creating links to obtain node metrics #3228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
| @@ -36,31 +36,40 @@ const ( | |||
| CustomNodeMemUsageAvg = "node_memory_usage_avg" | |||
| ) | |||
|
|
|||
| type CustomMetricsClient struct { | |||
| config *rest.Config | |||
| type KMetricsClient struct { | |||
There was a problem hiding this comment.
KMetricsClient is not a good name. What's the meaning of it?
There was a problem hiding this comment.
It means k8s metrics api client.
|
There is a ci failure @wangyang0616 |
Signed-off-by: wangyang0616 <wangyang8126@gmail.com>
wangyang0616
force-pushed
the
fix_usage_client
branch
from
e4507f1
to
6f16dc4
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After enabling the load-aware scheduling capability, Volcano will obtain node monitoring data through the Custom metrics API.
Optimize the logic of the link with the apiserver to avoid repeated link creation, resulting in increased pressure on the apiserver.