-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The status of a pod group is updated only when the pod group changes. #3081
The status of a pod group is updated only when the pod group changes. #3081
Conversation
…The status is not updated when the pod group does not change. Signed-off-by: w00568049 <wangyang289@huawei.com>
@@ -61,9 +58,6 @@ func isPodGroupConditionsUpdated(newCondition, oldCondition []scheduling.PodGrou | |||
|
|||
newTime := newCond.LastTransitionTime | |||
oldTime := oldCond.LastTransitionTime | |||
if TimeJitterAfter(newTime.Time, oldTime.Time, jobConditionUpdateTime, jobConditionUpdateTimeJitter) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the backgroud of update podgroup in a period of time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This item is added to reduce the number of access times of the API server. However, this item does not take effect. The initial hope is that the condition is inconsistent and the timing exceeds one minute. Update the apiserver.
I have verified that the pod group status does not change when the pod group is in the running state. When the pod group is in the pending or inqueue state, the pod group status does not change frequently. Therefore, I think the 1-minute interval can be deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
fix: #3080