Some yaml fix and cleanups after kube-batch in tree #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/L
k82cn
reviewed
Jul 8, 2019
| @@ -72,7 +71,7 @@ func buildConfig(opt *options.ServerOption) (*rest.Config, error) { | |||
| return cfg, nil | |||
| } | |||
|
|
|||
| // Run the kubeBatch scheduler | |||
| // Run the kube-batch scheduler | |||
There was a problem hiding this comment.
sorry, i missed this.
As there are many cleanup work left, let me open an issue
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: hzxuzhonghu, k82cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
wangyuqing4
pushed a commit
to wangyuqing4/volcano-1
that referenced
this pull request
Jul 9, 2019
Added e2e test by dind.
|
cc @TommyLike |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.