Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

supprot mgpu feature for volcano #3030

Open
wants to merge 5 commits into
base: release-1.8
Choose a base branch
from
Open

supprot mgpu feature for volcano #3030

wants to merge 5 commits into from

Conversation

chenxi-seu
Copy link

relative issue
#2711
#3009

@volcano-sh-bot
Copy link
Contributor

Welcome @chenxi-seu!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 3, 2023
@volcano-sh-bot volcano-sh-bot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Aug 3, 2023
@chenxi-seu chenxi-seu changed the base branch from master to release-1.8 August 3, 2023 02:32
shinytang6
shinytang6 reviewed Aug 3, 2023
View reviewed changes
Copy link
Member

@shinytang6 shinytang6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l have some questions, just curious:

  1. will be any follow up commits submitted to volcano device plugin later?
  2. how should users use this feature locally without mgpu kernel module? l think it should only be available on bytedance volcano engine?

@chenxi-seu chenxi-seu force-pushed the feat-mgpu branch 2 times, most recently from 03ce2ab to 58748e9 Compare August 16, 2023 04:54
@chenxi-seu chenxi-seu closed this Aug 16, 2023
@chenxi-seu chenxi-seu reopened this Aug 16, 2023
@chenxi-seu chenxi-seu marked this pull request as ready for review August 21, 2023 03:35
@volcano-sh-bot volcano-sh-bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 21, 2023
supprot mgpu feature for volcano
4698ac2 
Signed-off-by: jiangchenxi.530 <jiangchenxi.530@bytedance.com>
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@chenxi-seu
Copy link
Author

@shinytang6 Sorry for late response.

  1. This PR will not be merge to master, just for user pull. There may be enhancements or bug fix updates in the future.
  2. Yes, currently only available on the bytedance volcano engine, as it relies on kernel support for mgpu-driver.

fix Filter and Allocate in mgpu device
b8fa22b 
Signed-off-by: jiangchenxi.530 <jiangchenxi.530@bytedance.com>
add deepcopy to Devices interface and remove allocate in mgpu device
1e7f04a 
Signed-off-by: jiangchenxi.530 <jiangchenxi.530@bytedance.com>
jiangchenxi.530 and others added 2 commits October 19, 2023 15:13
fix AddResource including all mGPU pods
78c6027 
Signed-off-by: jiangchenxi.530 <jiangchenxi.530@bytedance.com>
@chenxi-seu
fix gpu device operation panic when nil happened
cf96079 
Signed-off-by: 杜占伟 <duzhanwei@bytedance.com>
@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 8, 2024
@volcano-sh-bot
Copy link
Contributor

@chenxi-seu: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shinytang6 shinytang6 shinytang6 left review comments

@merryzhou merryzhou Awaiting requested review from merryzhou

@Thor-wl Thor-wl Awaiting requested review from Thor-wl

@wpeng102 wpeng102 Awaiting requested review from wpeng102

Assignees
No one assigned
Labels
needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenxi-seu @volcano-sh-bot @shinytang6