fix: task-topology plugin cannot handle the tasks whose name contains -

[loheagn]

fix #2939

[volcano-sh-bot]

Welcome @loheagn! It looks like this is your first PR to volcano-sh/volcano 🎉

[hwdef]

@wangyang0616
Please help me trigger the CI of this PR

[lowang-bh]

how about add some comments of the task name format in following codes. The task's name is from pod name which generate by job controlller.

		i := len(task.Name) - 1
		for ; task.Name[i] != '-'; i-- {
		}
		tmpTaskName := strings.TrimPrefix(task.Name[:i], jobNamePrefix)

FYI:

volcano/pkg/controllers/job/job_controller_util.go

Line 39 in ed5c215

func MakePodName(jobName string, taskName string, index int) string {

[lowang-bh]

volcano/pkg/controllers/job/job_controller_util.go

Line 39 in ed5c215

func MakePodName(jobName string, taskName string, index int) string {

how about add some comments of the task name format.The task's name is from pod name which generate by job controlller.

[loheagn]

It looks sensible. I'll update it.

[stale]

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

[loheagn]

@lowang-bh Hi, could help to reopen this pr? I forget to update this pr for a long time......

[lowang-bh]

/reopen

[volcano-sh-bot]

@lowang-bh: Reopened this PR.

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Monokaix]

@loheagn Hi, are you still work on this?

[loheagn]

@loheagn Hi, are you still work on this?

@Monokaix Yes, but I dismiss the reopen event.....

I'll update the code recently.

[loheagn]

@Monokaix Hi, I fixed the CI and this pr is ready for review

[Monokaix]

/lgtm

[loheagn]

hello, @Monokaix could we move this PR forward?

[william-wang]

/approve

[volcano-sh-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pkg/scheduler/plugins/OWNERS [william-wang]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment