Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rescheduling related location logs #2698

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Add rescheduling related location logs #2698

merged 1 commit into from
Mar 6, 2023

Conversation

wangyang0616
Copy link
Member

  • Optimize the localization of rescheduling scheduling function
  • Delete extra spaces at the end of the line to solve the problem of kubectl viewing configmap with confusing format

@volcano-sh-bot volcano-sh-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 23, 2023
@volcano-sh-bot volcano-sh-bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 23, 2023
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2023
hwdef
hwdef reviewed Feb 27, 2023
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Feb 27, 2023
@wangyang0616
Optimize the localization of rescheduling scheduling function
d18355d 
Signed-off-by: wangyang <wangyang8126@gmail.com>
@volcano-sh-bot volcano-sh-bot removed the lgtm Indicates that a PR is ready to be merged. label Mar 2, 2023
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jiangkaihua
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2023
@volcano-sh-bot volcano-sh-bot merged commit 21bfb68 into volcano-sh:master Mar 6, 2023
@wangyang0616 wangyang0616 mentioned this pull request Jul 29, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@Thor-wl Thor-wl Thor-wl approved these changes

@k82cn k82cn Awaiting requested review from k82cn

@shinytang6 shinytang6 Awaiting requested review from shinytang6

Assignees

@hwdef hwdef

@jiangkaihua jiangkaihua

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wangyang0616 @volcano-sh-bot @jiangkaihua @hwdef @Thor-wl