Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move spark e2e integration from self-hosted to github-hosted #2590

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

Yikun
Copy link
Member

@Yikun Yikun commented Dec 3, 2022

This patch moves spark e2e integration from self-hosted runner to github-hosted runner.

  • Change self-hosted runner (ubuntu-20.04-spark) to github-hosted runner (ubuntu-20.04)
  • Upgrade actions/docker actions to latest to cleanup infra warning
  • Add java/scala cache to speed up test.
  • Remove Replace mirror because we don't need it in github-hosted runner
  • Add resource limited conf to make it work
  • Add volcano log like: [WIP] Add Volcano log collect in Spark IT #2205

Time cost: from 12 mins to 20 mins, I believe it's OK.

Related: #1704

Signed-off-by: Yikun Jiang yikunkero@gmail.com

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 3, 2022
@Yikun
Copy link
Member Author

Yikun commented Dec 3, 2022

cc @william-wang @Thor-wl @martin-g

After this, we can use the github-hosted runner instead the self-hosted runner (currently, a vm in Huawei Cloud ECS).

This way has already used in apache/spark apache/spark@5e6aab4 since Jul. 2022, it's been very stable according to last half year build history.

@Yikun
Copy link
Member Author

Yikun commented Dec 3, 2022

[info] VolcanoSuite:
[info] - Run SparkPi with volcano scheduler (19 seconds, 931 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minCPU (51 seconds, 656 milliseconds)
[info] - SPARK-38187: Run SparkPi Jobs with minMemory (53 seconds, 628 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (only 1 enabled) (21 seconds, 197 milliseconds)
[info] - SPARK-38188: Run SparkPi jobs with 2 queues (all enabled) (35 seconds, 323 milliseconds)
[info] - SPARK-38423: Run driver job to validate priority order (37 seconds, 470 milliseconds)
[info] Run completed in 4 minutes, 21 seconds.
[info] Total number of tests run: 6
[info] Suites: completed 3, aborted 0
[info] Tests: succeeded 6, failed 0, canceled 0, ignored 0, pending 0
[info] All tests passed.

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 6, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 6, 2022
@volcano-sh-bot volcano-sh-bot merged commit f8674d7 into volcano-sh:master Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants