Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The requests of extended resource(such as nvidia.com/gpu) is missing in PodGroup's minResource #2573

Merged
merged 2 commits into from
Dec 30, 2022

Conversation

jimoosciuc
Copy link
Contributor

resolves #2564

@volcano-sh-bot
Copy link
Contributor

Welcome @jimoosciuc!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 18, 2022
@jimoosciuc jimoosciuc changed the title External resource requests is missing in PodGroup's minResource The requests of extended resource(such as nvidia.com/gpu) is missing in PodGroup's minResource Nov 18, 2022
…ia.com/gpu) is missing

Signed-off-by: jimoosciuc <bruceleee522@gmail.com>
Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Dec 30, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 30, 2022
@volcano-sh-bot volcano-sh-bot merged commit f09fb54 into volcano-sh:master Dec 30, 2022
@stingshen
Copy link

Also fixes issue: #2615

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GPU Resource Are Not Taken into Account in Enqueue Action
4 participants