Bump ginkgo version to v2.3.0 #2532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/kind bug |
volcano-sh-bot
added
kind/bug
kerthcet
commented
Oct 12, 2022
kerthcet
force-pushed
the
fix/ginkgo-version
branch
from
b503eda
to
463b2bb
Compare
volcano-sh-bot
added
size/M
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
fix/ginkgo-version
branch
from
463b2bb
to
c246e6c
Compare
volcano-sh-bot
added
size/XXL
kerthcet
changed the title
kerthcet
force-pushed
the
fix/ginkgo-version
branch
2 times, most recently
from
950d5ef
to
908c33b
Compare
|
/hold |
volcano-sh-bot
added
the
do-not-merge/hold
kerthcet
force-pushed
the
fix/ginkgo-version
branch
from
908c33b
to
5b324bb
Compare
Signed-off-by: kerthcet <kerthcet@gmail.com>
kerthcet
force-pushed
the
fix/ginkgo-version
branch
from
5b324bb
to
382ab35
Compare
|
@hzxuzhonghu Would you mind to take a look, this is all I done here:
|
|
Actually this is an urgent problem, for all the PRs are blocked in merging. cc @Thor-wl @william-wang |
hwdef
reviewed
Oct 13, 2022
volcano-sh-bot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: kerthcet kerthcet@gmail.com
CI failed because of the latest ginkgo introduced a new feature grace-period in v2.3.0,but we use v2.0.0 in volcano. I'd like to specify ginkgo version as documented in go.mod
in case of the incompatible release.
RE:
CI failed because of the latest ginkgo introduced a new feature grace-period in v2.3.0, bump ginkgo version to v2.3.0
Special Notes:
go mod tidy && go mod vendorto update dependencies.hack/update-vendor-licenses.shto makemake verifypassed.