try get get old pg when new pg not exist #2400
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/M
added 2 commits
July 30, 2022 10:42
Signed-off-by: Qiuyu Wu <qiuyu.wu@shopee.com>
Signed-off-by: Qiuyu Wu <qiuyu.wu@shopee.com>
Akiqqqqqqq
force-pushed
the
bugfix-pg-name-uuid
branch
from
c6172f3
to
d621c91
Compare
Thor-wl
requested review from
shinytang6,
wpeng102,
Thor-wl and
william-wang
and removed request for
hzxuzhonghu and
yuanchen8911
|
Thanks for your contribution. I think it is important for users who upgrades volcano versions from below v1.6.0 to v1.6.0. |
|
/lgtm |
hzxuzhonghu
reviewed
Aug 1, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
william-wang
pushed a commit
to william-wang/volcano
that referenced
this pull request
Aug 1, 2022
try get get old pg when new pg not exist
william-wang
pushed a commit
to william-wang/volcano
that referenced
this pull request
Aug 1, 2022
try get get old pg when new pg not exist Signed-off-by: william-wang <wang.platform@gmail.com>
QingyaFan
added a commit
to QingyaFan/volcano
that referenced
this pull request
Aug 5, 2024
v1.5 changed the naming logics of pod group by adding UID into the name: volcano-sh#2140, and there is also another fix regarding handling the already created pod group without UID in create or update: volcano-sh#2400. But a similar fix does not exist in the syncJob function. Fixes volcano-sh#3640
QingyaFan
added a commit
to QingyaFan/volcano
that referenced
this pull request
Aug 5, 2024
v1.5 changed the naming logics of pod group by adding UID into the name, and there is a fix handling the already created pod group without UID in create or update: volcano-sh#2400. But similar fix does not exist in syncJob function. Fixes volcano-sh#3640
QingyaFan
added a commit
to QingyaFan/volcano
that referenced
this pull request
Aug 5, 2024
v1.5 changed the naming logics of pod group by adding UID into the name, and there is a fix handling the already created pod group without UID in create or update: volcano-sh#2400. But similar fix does not exist in syncJob function. Fixes volcano-sh#3640 Signed-off-by: cheerfun <qingyafan@outlook.com>
QingyaFan
added a commit
to QingyaFan/volcano
that referenced
this pull request
Aug 6, 2024
v1.5 changed the naming logics of pod group by adding UID into the name, and there is a fix handling the already created pod group without UID in create or update: volcano-sh#2400. But similar fix does not exist in syncJob function. Fixes volcano-sh#3640 Signed-off-by: cheerfun <qingyafan@outlook.com>
QingyaFan
added a commit
to QingyaFan/volcano
that referenced
this pull request
Aug 6, 2024
v1.5 changed the naming logics of pod group by adding UID into the name, and there is a fix handling the already created pod group without UID in create or update: volcano-sh#2400. But similar fix does not exist in syncJob function. Fixes volcano-sh#3640 Signed-off-by: cheerfun <qingyafan@outlook.com>
QingyaFan
added a commit
to QingyaFan/volcano
that referenced
this pull request
Aug 8, 2024
…#3640 v1.5 changed the naming logics of pod group by adding UID into the name: volcano-sh#2140, and there is also another fix regarding handling the already created pod group without UID in create or update: volcano-sh#2400. But a similar fix does not exist in the syncJob function. Fixes volcano-sh#3640
QingyaFan
added a commit
to QingyaFan/volcano
that referenced
this pull request
Aug 8, 2024
…#3640 v1.5 changed the naming logics of pod group by adding UID into the name: volcano-sh#2140, and there is also another fix regarding handling the already created pod group without UID in create or update: volcano-sh#2400. But a similar fix does not exist in the syncJob function. Fixes volcano-sh#3640 Signed-off-by: cheerfun <qingyafan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Qiuyu Wu qiuyu.wu@shopee.com
fix：#2389
what happen:
after this feature #2140 applied, error comes when upgrading volcano from 1.4 to 1.6, details showed in #2389.
this is because volcano-job-controller creates extra pgs with job uid suffix for existing jobs, which are already running, and thus two pgs exist in cluster for one vj. when existing jobs are using over half of the cluster resource already, the new pgs with uid will cause inqueue get larger in proportion AddJobEnqueueableFn (line 334 in pkg/scheduler/plugins/proportion/proportion.go). after inqueue gets larger than realCapability, the new coming jobs will pend forever