-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add rest config into ssn #2378
add rest config into ssn #2378
Conversation
Signed-off-by: wpeng102 <wpeng102@126.com>
Sound reasonable.That's OK for me. |
The plugins are created and destroyed each scheduling cycle, do you recreate the informers every time? If it's not, do you think it's a good option to put these informer creations somewhere before the session starts? |
Good question. Currently volcano plugin does not provide a informer function which can init the informer. I think customer can use a singleton function to init some variable to avoid recreate every scheduler period. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: william-wang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: wpeng102 wpeng102@126.com
Customer maybe introduce CRD resource for scheduling. So in scheduler plugin, customer maybe need construct this CRD's informer. Currently ssn only provide kubeclient for plugin, we need provide restconfig for customer to init customer resource client.