Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add rest config into ssn #2378

Merged
merged 1 commit into from
Jul 28, 2022
Merged

add rest config into ssn #2378

merged 1 commit into from
Jul 28, 2022

Conversation

wpeng102
Copy link
Member

@wpeng102 wpeng102 commented Jul 25, 2022

Signed-off-by: wpeng102 wpeng102@126.com

Customer maybe introduce CRD resource for scheduling. So in scheduler plugin, customer maybe need construct this CRD's informer. Currently ssn only provide kubeclient for plugin, we need provide restconfig for customer to init customer resource client.

Signed-off-by: wpeng102 <wpeng102@126.com>
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 25, 2022
@Thor-wl Thor-wl requested review from qiankunli, Thor-wl, hwdef, shinytang6 and william-wang and removed request for hudson741 and alcorj-mizar July 25, 2022 06:42
@Thor-wl
Copy link
Contributor

Thor-wl commented Jul 25, 2022

Sound reasonable.That's OK for me.
/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2022
@elinx
Copy link

elinx commented Jul 25, 2022

The plugins are created and destroyed each scheduling cycle, do you recreate the informers every time?

If it's not, do you think it's a good option to put these informer creations somewhere before the session starts?

@wpeng102
Copy link
Member Author

The plugins are created and destroyed each scheduling cycle, do you recreate the informers every time?

If it's not, do you think it's a good option to put these informer creations somewhere before the session starts?

Good question. Currently volcano plugin does not provide a informer function which can init the informer. I think customer can use a singleton function to init some variable to avoid recreate every scheduler period.

Copy link
Member

@william-wang william-wang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: william-wang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 28, 2022
@volcano-sh-bot volcano-sh-bot merged commit d4f928f into volcano-sh:master Jul 28, 2022
@wpeng102 wpeng102 deleted the restconfig branch July 29, 2022 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants