fix bug in task dependsOn #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
size/S
hwdef
force-pushed
the
fix-task-dependsOn
branch
from
e4f370d
to
a205406
Compare
|
/assign @Thor-wl @shinytang6 @william-wang |
Thor-wl
requested review from
Thor-wl,
william-wang and
wpeng102
and removed request for
hzxuzhonghu
Thor-wl
reviewed
Jul 19, 2022
| if err != nil { | ||
| klog.Errorf("Failed to get pod %v/%v %v", job.Namespace, podName, err) | ||
| continue | ||
| // If pod is not found. There are 2 possibilities. |
There was a problem hiding this comment.
It's OK for me. Some small tip:
- The commments can be reorganized to be simple.
- The last
elsebranch is redudant and can be removed.
There was a problem hiding this comment.
@Thor-wl
Thanks for you suggestions. I made some changes.
Signed-off-by: hwdef <hwdefcom@outlook.com>
hwdef
force-pushed
the
fix-task-dependsOn
branch
from
a205406
to
cd18865
Compare
volcano-sh-bot
added
size/XS
Thor-wl
approved these changes
Jul 21, 2022
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Thor-wl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2345 #2284 #2130
This PR can greatly reduce the chance of bug triggering.
As long as the user does not deploy a vcjob with the same name again in less than
--detection-period-of-dependson-task, the bug will not be triggered.The default value of
--detection-period-of-dependson-taskis 100 milliseconds.