Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UT cases for Job Package - job_controller_actions.go #235

Merged
merged 4 commits into from
Jun 21, 2019

Conversation

thandayuthapani
Copy link
Contributor

For #168
Added UT cases for job_controller_actions.go in Job Package

ExpextVal error
}{
{
Name: "KillJob Sucess Case",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: success and same for the below

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made

@TommyLike
Copy link
Contributor

/lgtm

@asifdxtreme asifdxtreme requested a review from k82cn June 20, 2019 05:33
@k82cn
Copy link
Member

k82cn commented Jun 21, 2019

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Jun 21, 2019
@volcano-sh-bot volcano-sh-bot merged commit 2797241 into volcano-sh:master Jun 21, 2019
kevin-wangzefeng pushed a commit to kevin-wangzefeng/volcano that referenced this pull request Jun 28, 2019
UT cases for Job Package - job_controller_actions.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants