Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

To record the start and end time of job scheduling #2318

Merged
merged 2 commits into from
Jul 5, 2022
Merged

To record the start and end time of job scheduling #2318

merged 2 commits into from
Jul 5, 2022

Conversation

dontan001
Copy link
Contributor

This is to fix the issue #2312

@volcano-sh-bot
Copy link
Contributor

Welcome @dontan001!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 30, 2022
@dontan001 dontan001 mentioned this pull request Jun 30, 2022
Closed
@Thor-wl Thor-wl requested review from Thor-wl, hwdef, shinytang6 and william-wang and removed request for hudson741 and k82cn June 30, 2022 09:38
@hwdef
Copy link
Member

hwdef commented Jun 30, 2022

please fix the DCO,
LGTM

@dontan001
To record the last time of job scheduling
a9cc4e7 
Signed-off-by: dongge.tan <dontan001@hotmail.com>
@dontan001 dontan001 closed this Jul 1, 2022
@volcano-sh-bot volcano-sh-bot added retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@dontan001 dontan001 reopened this Jul 1, 2022
@volcano-sh-bot volcano-sh-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed retest-not-required-docs-only approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 1, 2022
@dontan001
Copy link
Contributor Author

please fix the DCO, LGTM

Fixed, thanks
/assign @hwdef

@dontan001 dontan001 requested a review from hwdef July 1, 2022 01:39
@hwdef
Copy link
Member

hwdef commented Jul 1, 2022

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 1, 2022
@dontan001
to record the start time of job scheduling
25021d6 
Signed-off-by: dongge.tan <dontan001@hotmail.com>
@volcano-sh-bot volcano-sh-bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jul 1, 2022
@dontan001 dontan001 changed the title To record the last time of job scheduling To record the start and end time of job scheduling Jul 1, 2022
@dontan001
Copy link
Contributor Author

@hwdef I refined the PR commits to expose the start time metrics as well in Volcano. Thus it is not a must for users to deploy the kube-state-metrics

I also update this in the thread of issue #2312

hwdef
hwdef reviewed Jul 4, 2022
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 4, 2022
@hwdef
Copy link
Member

hwdef commented Jul 4, 2022

please make CI happy

@dontan001
Copy link
Contributor Author

/retest

@volcano-sh-bot
Copy link
Contributor

@dontan001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dontan001
Copy link
Contributor Author

/ok-to-test

@volcano-sh-bot
Copy link
Contributor

@dontan001: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dontan001
Copy link
Contributor Author

please make CI happy

Hi @hwdef , can you please help trigger a retest? since the error in the CI log does not relate to my PR in first glance.
If the error keeps happening, I can investigate further
Thanks

@dontan001
Copy link
Contributor Author

All the checks passed, please help approve @hwdef @Thor-wl @william-wang

@dontan001 dontan001 requested a review from hwdef July 5, 2022 01:33
@Thor-wl
Copy link
Contributor

Thor-wl commented Jul 5, 2022

/approve

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 5, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot merged commit 57e90ac into volcano-sh:master Jul 5, 2022
@dontan001
Copy link
Contributor Author

/approve

Thanks for the help @Thor-wl @hwdef @william-wang

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thor-wl Thor-wl Thor-wl approved these changes

@shinytang6 shinytang6 Awaiting requested review from shinytang6

@william-wang william-wang Awaiting requested review from william-wang

@hwdef hwdef Awaiting requested review from hwdef

Assignees

@hwdef hwdef

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dontan001 @volcano-sh-bot @hwdef @Thor-wl