Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: All pods is existing when restart count exceed max retry #1997

Merged
merged 1 commit into from
Jan 30, 2022
Merged

Fix: All pods is existing when restart count exceed max retry #1997

merged 1 commit into from
Jan 30, 2022

Conversation

william-wang
Copy link
Member

cherry-pick #1719

Signed-off-by: lubingtan lubingtan@126.com

@LuBingtan @william-wang
Fix kill job, do not delete failed/succeeded pods at last retry, add …
e1a94b6 
…e2e test for job retry

Signed-off-by: lubingtan <lubingtan@126.com>
@volcano-sh-bot volcano-sh-bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 30, 2022
@Thor-wl
Copy link
Contributor

Thor-wl commented Jan 30, 2022

/lgtm
/approve

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 30, 2022
@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Thor-wl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 30, 2022
@Thor-wl Thor-wl merged commit 8423cb5 into volcano-sh:release-1.4 Jan 30, 2022
@k82cn
Copy link
Member

k82cn commented Feb 1, 2022

Why this PR was merged without CI passed?

@Thor-wl
Copy link
Contributor

Thor-wl commented Feb 7, 2022 •
edited
Loading

Why this PR was merged without CI passed?

Some pre-installed clients such as ginkgo and golint in Github action CI machines has been update from v1 to v2, which introduces a lot of adoption work, otherwise all PRs will not pass the current CI. This adoption can been refered to #1932. This commits has been merged to master branch but not to other branches for it's not a code bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzxuzhonghu hzxuzhonghu Awaiting requested review from hzxuzhonghu

@yuanchen8911 yuanchen8911 Awaiting requested review from yuanchen8911

Assignees

@Thor-wl Thor-wl

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@william-wang @Thor-wl @volcano-sh-bot @k82cn @LuBingtan