Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove scheduling.v1alpha1 and scheduling.v1alpha2 API #692

Closed
k82cn opened this issue Feb 7, 2020 · 5 comments · Fixed by #693
Closed

Remove scheduling.v1alpha1 and scheduling.v1alpha2 API #692

k82cn opened this issue Feb 7, 2020 · 5 comments · Fixed by #693
Labels
api-review Categorizes an issue or PR as actively needing an API review. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Milestone
v0.4

Comments

@k82cn
Copy link
Member

k82cn commented Feb 7, 2020

Is this a BUG REPORT or FEATURE REQUEST?:

/kind feature

Description:

Currently, we have three versions of scheduling CRDs: scheduling.sigs.dev/v1alpha2, scheduling.incubator.k8s.io/v1alpha1 and scheduling.volcano.sh/v1beta1; that makes us hard to maintain those API in components.

So I'd like to REMOVE scheduling.sigs.dev/v1alpha2, scheduling.incubator.k8s.io/v1alpha1 and provide tools for migration.
@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Feb 7, 2020
@k82cn k82cn added api-review Categorizes an issue or PR as actively needing an API review. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. labels Feb 7, 2020
@k82cn k82cn added this to the v0.4 milestone Feb 7, 2020
@k82cn
Copy link
Member Author

k82cn commented Feb 7, 2020

/assign @thandayuthapani

@thandayuthapani , would you help on this one?

@volcano-sh-bot
Copy link
Contributor

@k82cn: GitHub didn't allow me to assign the following users: thandayuthapani.

Note that only volcano-sh members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @thandayuthapani

@thandayuthapani , would you help on this one?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k82cn
Copy link
Member Author

k82cn commented Feb 7, 2020

/cc @hzxuzhonghu , please work with @thandayuthapani on this one :)

@thandayuthapani
Copy link
Contributor

Yes @k82cn. I will work on this weekend for this issue.

@thandayuthapani thandayuthapani mentioned this issue Feb 7, 2020
Merged
@hzxuzhonghu
Copy link
Collaborator

Doesn't this make volcano incompatible?

@k82cn k82cn mentioned this issue Feb 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api-review Categorizes an issue or PR as actively needing an API review. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release.
Projects
None yet
Milestone
v0.4
Development

Successfully merging a pull request may close this issue.

Remove scheduling.v1alpha1 and scheduling.v1alpha2 API thandayuthapani/volcano
4 participants
@hzxuzhonghu @k82cn @thandayuthapani @volcano-sh-bot