Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest Removing copyright year from generated go files #3668

Closed
Monokaix opened this issue Aug 9, 2024 · 3 comments
Closed

Suggest Removing copyright year from generated go files #3668

Monokaix opened this issue Aug 9, 2024 · 3 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature.

Comments

@Monokaix
Copy link
Member

Monokaix commented Aug 9, 2024

What is the problem you're trying to solve

When using code-generator to generate files, the boilerplate is used and it contains YEAR field in copyright, so when we generate new files in current year, the year will be rendered, but the previous files will also be affected, which is unacceptable, and from kubernetes's practice, see kubernetes/gengo#24, there are no YEAR field in license header, so I suggest remove the YEAR field too, cause it has nothing to do with the license.

Describe the solution you'd like

Remove copyright year from generated go files, currently only API repo https://github.com/volcano-sh/apis has this problem, we can first start with the API repo.

Additional context

This pr volcano-sh/apis#134 is doing this when updating code generation scripts.

@Monokaix Monokaix added the kind/feature Categorizes issue or PR as related to a new feature. label Aug 9, 2024
@hwdef
Copy link
Member

hwdef commented Aug 9, 2024

It makes sense

@Monokaix
Copy link
Member Author

/close

@volcano-sh-bot
Copy link
Contributor

@Monokaix: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

No branches or pull requests

3 participants