Merge pull request #2652 from kingeasternsun/improve/remove-used-copy

🎈 perf(preempt): remove used copy
volcano-sh · Jan 16, 2023 · e145aff · e145aff
2 parents c451fea + bf385c9
commit e145aff
Showing 1 changed file with 1 addition and 5 deletions.
diff --git a/pkg/scheduler/actions/preempt/preempt.go b/pkg/scheduler/actions/preempt/preempt.go
@@ -298,11 +298,7 @@ func victimTasks(ssn *framework.Session) {
 	stmt := framework.NewStatement(ssn)
 	tasks := make([]*api.TaskInfo, 0)
 	victimTasksMap := ssn.VictimTasks(tasks)
-	victimTasks := make([]*api.TaskInfo, 0)
-	for task := range victimTasksMap {
-		victimTasks = append(victimTasks, task)
-	}
-	for _, victim := range victimTasks {
+	for victim := range victimTasksMap {
 		if err := stmt.Evict(victim.Clone(), "evict"); err != nil {
 			klog.Errorf("Failed to evict Task <%s/%s>: %v",
 				victim.Namespace, victim.Name, err)