Skip to content

Commit

Permalink
to record the start time of job scheduling
Browse files Browse the repository at this point in the history
Signed-off-by: dongge.tan <dontan001@hotmail.com>
  • Loading branch information
dontan001 committed Jul 1, 2022
1 parent a9cc4e7 commit 25021d6
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 0 deletions.
2 changes: 2 additions & 0 deletions pkg/scheduler/cache/event_handlers.go
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,8 @@ func (sc *SchedulerCache) setPodGroup(ss *schedulingapi.PodGroup) error {
sc.Jobs[job].Queue = schedulingapi.QueueID(sc.defaultQueue)
}

metrics.UpdateE2eSchedulingStartTimeByJob(sc.Jobs[job].Name, string(sc.Jobs[job].Queue), sc.Jobs[job].Namespace,
sc.Jobs[job].CreationTimestamp.Time)
return nil
}

Expand Down
1 change: 1 addition & 0 deletions pkg/scheduler/metrics/job.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ func RegisterJobRetries(jobID string) {
// DeleteJobMetrics delete all metrics related to the job
func DeleteJobMetrics(jobName, queue, namespace string) {
e2eJobSchedulingDuration.DeleteLabelValues(jobName, queue, namespace)
e2eJobSchedulingStartTime.DeleteLabelValues(jobName, queue, namespace)
e2eJobSchedulingLastTime.DeleteLabelValues(jobName, queue, namespace)
unscheduleTaskCount.DeleteLabelValues(jobName)
jobShare.DeleteLabelValues(namespace, jobName)
Expand Down
14 changes: 14 additions & 0 deletions pkg/scheduler/metrics/metrics.go
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,15 @@ var (
[]string{"job_name", "queue", "job_namespace"},
)

e2eJobSchedulingStartTime = promauto.NewGaugeVec(
prometheus.GaugeOpts{
Subsystem: VolcanoNamespace,
Name: "e2e_job_scheduling_start_time",
Help: "E2E job scheduling start time",
},
[]string{"job_name", "queue", "job_namespace"},
)

e2eJobSchedulingLastTime = promauto.NewGaugeVec(
prometheus.GaugeOpts{
Subsystem: VolcanoNamespace,
Expand Down Expand Up @@ -160,6 +169,11 @@ func UpdateE2eSchedulingDurationByJob(jobName string, queue string, namespace st
e2eJobSchedulingLatency.Observe(DurationInMilliseconds(duration))
}

// UpdateE2eSchedulingStartTimeByJob updates the start time of scheduling
func UpdateE2eSchedulingStartTimeByJob(jobName string, queue string, namespace string, t time.Time) {
e2eJobSchedulingStartTime.WithLabelValues(jobName, queue, namespace).Set(ConvertToUnix(t))
}

// UpdateE2eSchedulingLastTimeByJob updates the last time of scheduling
func UpdateE2eSchedulingLastTimeByJob(jobName string, queue string, namespace string, t time.Time) {
e2eJobSchedulingLastTime.WithLabelValues(jobName, queue, namespace).Set(ConvertToUnix(t))
Expand Down

0 comments on commit 25021d6

Please sign in to comment.