Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vk- to vc- #8

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Conversation

asifdxtreme
Copy link
Contributor

Resolves volcano-sh/volcano#286 partially

@volcano-sh-bot
Copy link
Collaborator

Welcome @asifdxtreme!

It looks like this is your first PR to volcano-sh/charts 🎉.

Thank you, and welcome to Volcano. 😃

@asifdxtreme asifdxtreme removed the request for review from kevin-wangzefeng July 9, 2019 10:20
@volcano-sh-bot volcano-sh-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 9, 2019
@TommyLike
Copy link
Contributor

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 9, 2019
@k82cn
Copy link
Collaborator

k82cn commented Jul 9, 2019

/approve

|`basic.scheduler_image_name`|Scheduler Docker Image Name|`volcanosh/vk-kube-batch`|
|`basic.admission_image_name`|Admission Controller Image Name|`volcanosh/vk-admission`|
|`basic.controller_image_name`|Controller Docker Image Name|`volcanosh/vc-controllers`|
|`basic.scheduler_image_name`|Scheduler Docker Image Name|`volcanosh/vc-kube-batch`|
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

btw, let's change to vc-scheduler in other PR.

@volcano-sh-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: asifdxtreme, k82cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 9, 2019
@volcano-sh-bot volcano-sh-bot merged commit 8ed7d2c into volcano-retired:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update abbreviation of Volcano from vk-* to vc-*
4 participants