Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linux: update bash plugin to only get memory sections once #1035

Merged

Conversation

eve-mem
Copy link
Contributor

@eve-mem eve-mem commented Nov 10, 2023

Hello,

After seeing that the Linux bash plugin calls the get_process_memory_sections function twice to get the same results in #1034

I felt like I had to change it to be the smallest most insignificant amount more efficient. It likely makes no difference with older kernels that don't use maple tree structures, but in 6.1+ parsing the tree is at least a little bit more work so it makes sense to only do it once.

This doesn't change how the plugin works or what any of the functions return, they all work exactly as they did before - perhaps meaning this PR wasn't worth wasting anyone time with....

Copy link
Member

@ikelos ikelos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, that's exactly the kind of efficiency improvement we like! It may seem small now, but when it's done a LOT, it adds up! 5:)

@ikelos ikelos merged commit 2e4d6cd into volatilityfoundation:develop Nov 15, 2023
14 checks passed
@eve-mem eve-mem deleted the linux_bash_get_sections_only_once branch December 1, 2023 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants