Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Map instead of object for record file name key #59

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

franz-bendezu
Copy link
Contributor

@franz-bendezu franz-bendezu commented Aug 12, 2023

Hello,
I've tackled an issue regarding the optional dirs and files properties within the Dir structure. Although these properties were initially presented as always present, it has become apparent that they might not always be available. This PR aims to refine the handling of these optional properties to ensure a more robust and accurate behavior within the Dir structure.

@johnsoncodehk
Copy link
Member

Although these properties were initially presented as always present, it has become apparent that they might not always be available.

Thanks a lot for the PR! Can you explain how this happens?

@johnsoncodehk johnsoncodehk linked an issue Oct 6, 2023 that may be closed by this pull request
@johnsoncodehk johnsoncodehk changed the title Hotfix: improvee types for Dir with optional files and dirs fix: use Map instead of object for record file name key Oct 6, 2023
@johnsoncodehk johnsoncodehk merged commit cfc6b9b into volarjs:master Oct 6, 2023
3 checks passed
@johnsoncodehk
Copy link
Member

Made some updates, the problem has been investigated in #65!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Directory named "constructor" could crash
2 participants