Adding 'id' to DOMNodes with type string.

[devteam-emroc]

Fixing the PHP8.3 type error "Cannot assign null to property DOMElement::$id of type string"

---

This change is 

[sonarqubecloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[devteam-emroc]

@voku would be great if we have a PHP8.3 compatibile version.

[acharron-hl]

@voku Any chance we could get a review on this and a release after?

In the meantime for anyone running into this issue, the following in your composer.json ought to be a workaround:

{
    "repositories": [
        {
            "type": "vcs",
            "url": "https://github.com/devteam-emroc/simple_html_dom"
        }
    ],
    "require_dev": {
        "voku/simple_html_dom": "dev-php-83 as 4.8.8",
    }
}

[ConnectGrid]

This fix involves adding a static class property:

protected static $stringDomNodes = [
    'id',
    'prefix',
    'content'
];

Would it make more sense to use an array constant?

protected const STRING_DOM_NODES = [ ... ];

Just a thought.

[repat]

@voku Could you please merge this?

[Brenneisen]

@voku The error is unfortunately blocking the update to PHP 8.3. Would it be possible for you to merge this shortly? Thank you!

[acharron-hl]

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @devteam-emroc)