-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for Jupyter Client 7 #953
Conversation
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2021-10-07 09:43:28.726210320 +0000
+++ /dev/fd/62 2021-10-07 09:43:28.726210320 +0000
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.8.0-1042-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
"release": "20.04.3 LTS",
- "serial": "6c19bc2f6263432da3d31804b6f46a17",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
Adding to the |
7540504
to
1bf5f31
Compare
1bf5f31
to
e278ee4
Compare
Marking as ready for review now that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
Fix the issue (voila-dashboards/voila#941) already fixed for PyPI version here: voila-dashboards/voila#953
References
Fixes #941
Code changes
Update dependency pin on
jupyter_client
to allow for version 7User-facing changes
None
Backwards-incompatible changes
?