Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Binder on PR workflow #949

Merged
merged 3 commits into from
Sep 6, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 3, 2021

References

Similar setup as the ipywidgets repo: https://github.com/jupyter-widgets/ipywidgets

This will help test changes on Binder without having to check out the code locally.

Code changes

Binder configuration.

User-facing changes

Users and contributors can test their changes on Binder.

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.2.x milestone Sep 3, 2021
@jtpio
Copy link
Member Author

jtpio commented Sep 3, 2021

The action will add Binder buttons like the following on new PRs:

Binder

@jtpio jtpio marked this pull request as ready for review September 3, 2021 16:39
@jtpio
Copy link
Member Author

jtpio commented Sep 3, 2021

This also means we won't be using a released version of voila on Binder in this repo.

But it should be fine since the stable branch will still point to a release commit. The difference will be that voila will be built from source.

We can always quickly setup GitHub gists with voila releases if needed.

@jtpio jtpio merged commit e89c240 into voila-dashboards:master Sep 6, 2021
@jtpio jtpio deleted the binder-prs branch September 6, 2021 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant