Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unpin xtl=0.6.23 in the tests #815

Merged
merged 1 commit into from
Jan 27, 2021
Merged

Unpin xtl=0.6.23 in the tests #815

merged 1 commit into from
Jan 27, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 22, 2021

Fixes #812

@jtpio
Copy link
Member Author

jtpio commented Jan 25, 2021 •
edited
Loading

Failing with the xcpp11 kernel: https://github.com/voila-dashboards/voila/runs/1751284846

Passing with xcpp14: https://github.com/voila-dashboards/voila/runs/1760800651

This is with xeus-cling=0.12.0 and xtl=0.7.0:

image

@JohanMabille
Copy link
Member

Looks like xcpp11 doe snot even start with the latest release ;( Need to investigate this.

@jtpio jtpio marked this pull request as ready for review January 27, 2021 07:31
@jtpio
Copy link
Member Author

jtpio commented Jan 27, 2021

Thanks @JohanMabille for the fix!

@jtpio jtpio merged commit f75dc9a into voila-dashboards:master Jan 27, 2021
@jtpio jtpio deleted the unpin-xtl branch January 27, 2021 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unpin xtl in the tests
2 participants
@jtpio @JohanMabille