Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow for packaging #798

Merged
merged 1 commit into from
Jan 11, 2021
Merged

Add CI workflow for packaging #798

merged 1 commit into from
Jan 11, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 8, 2021

To test installing voila and double check the packaging is correct.

Heavily based on the work from @bollwyvl in jupyterlab/retrolab#68. Thanks!

Co-authored-by: Nicholas Bollweg <nick.bollweg@gmail.com>
@jtpio
Copy link
Member Author

jtpio commented Jan 8, 2021

@bollwyvl I added you as co-author on the commit, hope it's fine!

cc @martinRenou if you want to review, since you did something similar in bqplot.

@jtpio jtpio marked this pull request as ready for review January 8, 2021 14:38
@bollwyvl
Copy link
Contributor

bollwyvl commented Jan 8, 2021

I guess we should add caching if people are going to start copy-pasting stuff. If i have to watch pyrsistent get built one more time...

@jtpio jtpio merged commit 9403715 into voila-dashboards:master Jan 11, 2021
@jtpio jtpio deleted the ci branch January 11, 2021 07:43
@martinRenou
Copy link
Member

Sorry I missed the notification! LGTM

@jtpio jtpio mentioned this pull request Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants