Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpin jupyter_server in the tests #794

Merged
merged 1 commit into from
Jan 6, 2021
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Jan 5, 2021

Unpin the jupyter_server dependency in the test extras_require, and define a base_url fixture instead.

Similar to voila-dashboards/voila-gridstack#74

@jtpio
Copy link
Member Author

jtpio commented Jan 5, 2021

We should be able to reuse the Jupyter Server pytest fixtures after switching to ExtensionApp.

@jtpio jtpio merged commit 8d9ac27 into voila-dashboards:master Jan 6, 2021
@jtpio jtpio deleted the tests branch January 6, 2021 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant