-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add show_tracebacks trait #630
Conversation
LGTM, only a flake issue. |
@maartenbreddels Well, it should preferably get a unit test, but since tests don't work on Windows I cannot really write it with confidence. |
Would you describe what does wrong? Maybe we should start adding it to CI? |
Tests should pass on Windows, although the Github action we are using is not compatible with Windows yet. |
Here are the results of following CONTRIBUTING.md:(voila) C:\dev\voila>python -m pytest ================================================= test session starts ================================================= platform win32 -- Python 3.8.5, pytest-5.4.3, py-1.9.0, pluggy-0.13.1 rootdir: C:\dev\voila plugins: jupyter-server-0.3.0, tornasync-0.6.0.post2 collected 37 items |
b891632
to
97c1829
Compare
Thanks @vidartf ! |
No worries. If anyone with a non-windows machine wants to write a test for it as well, that would probably be nice 👍 |
Closes voila-dashboards#751 This is a followup of voila-dashboards#630
Closes voila-dashboards#751 This is a followup of voila-dashboards#630
Fixes #616 .
Currently not tested as current tests fail on Windows 😢