-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simplify actions and use mamba #573
Simplify actions and use mamba #573
Conversation
c653dc0
to
dc46c2b
Compare
Now that we can drop 3.5, rebasing should get the tests to pass. |
4df5ce3
to
860f08f
Compare
Linking to the conversation on gitter: https://gitter.im/QuantStack/Lobby?at=5ee247be36589658b12b9026 We might want to try with It might even help fixing #526 too. |
wow thanks @martinRenou for the update. Let's see how it goes! |
I'll enable Windows too, see what happens |
Windows used to be an issue because of xeus-cling (but there could be a condition to handle that) |
Looks like |
The other jobs (ubuntu and macos) are passing, nice 👍 We could also fix windows separately. |
Yeah although there is still one failing on Macos. I'll look at it later. |
I rerun the test and it's now passing. There might be a race condition in the tests. Let's disable Windows tests for now and merge then. |
Signed-off-by: martinRenou <martin.renou@gmail.com>
6d19ecb
to
44b432f
Compare
@jtpio All green. Ok to merge? |
That looks good and much simpler, thanks a lot! Happy to go for it if we're fine using mamba on CI. |
No description provided.