Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Voila as an ExtensionApp (was #270) #563

Closed

Conversation

davidbrochart
Copy link
Member

Yet another shot at #270.
@Zsailer is mostly the author.

@vidartf
Copy link
Contributor

vidartf commented Mar 25, 2020

@Zsailer is mostly the author.

The git history does not reflect this though :-/

@davidbrochart
Copy link
Member Author

I know, but master has diverged too much. I found it easier to try and report the changes @Zsailer had done in his PR, to today's master.

@Zsailer
Copy link
Member

Zsailer commented Mar 25, 2020

Thanks, @vidartf. I'm really not worried about the credit. I appreciate the shout-out! 😄

In the meantime, Jupyter Server's extension API has diverged a bit since I made the original PR as well. I'm happy to jump on this PR with you @davidbrochart. I was planning to work on this extension as soon as released Jupyter Server 1.0 this week.

@maartenbreddels
Copy link
Member

This is actually #492 a continuation of right?

@davidbrochart
Copy link
Member Author

Yes, but I'm working on yet another one!

@davidbrochart
Copy link
Member Author

Closing in favor of #592.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants