Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup GitHub Actions for CI #445

Merged
merged 1 commit into from
Dec 4, 2019
Merged

Setup GitHub Actions for CI #445

merged 1 commit into from
Dec 4, 2019

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 25, 2019

Setup GitHub Actions for testing.

Github Actions Status

This is to evaluate GitHub Actions as a replacement for Travis CI, and eventually add Windows testing to Voila (xref #432).

I quickly tried windows-latest as well, but ran into issues with conda. And also the tests using xeus-cling will have to be disabled for Windows.

@maartenbreddels there is an official actions/setup-python@v1 for Python, but for conda we still have to do things manually it seems (setting up the path and activating the environment).

fail-fast: false
matrix:
os: [ubuntu-latest, macos-latest]
python-version: [2.7, 3.6, 3.7]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.8 not available on conda yet

Comment on lines +24 to +25
# sudo required?
sudo conda update -y -n base conda setuptools
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Permissions might be a bit strict with actions. This is what we get without sudo:

NotWritableError: The current user does not have write permissions to a required path.
  path: /Users/runner/.conda/pkgs/urls.txt
  uid: 501
  gid: 20

If you feel that permissions on this path are set incorrectly, you can manually
change them by executing

  $ sudo chown 501:20 /Users/runner/.conda/pkgs/urls.txt

In general, it's not advisable to use 'sudo conda'.

@jtpio
Copy link
Member Author

jtpio commented Oct 25, 2019

And to answer your question from earlier today @maartenbreddels, it seems to be (much) faster than on Travis 🚀

@jtpio jtpio changed the title Setup GitHub Action for CI Setup GitHub Actions for CI Oct 25, 2019
@maartenbreddels
Copy link
Member

I see no harm in merging this to see if we prefer this over Travis.

@jtpio
Copy link
Member Author

jtpio commented Dec 4, 2019

Yes. Let's merge then?

@maartenbreddels maartenbreddels merged commit 161bd68 into master Dec 4, 2019
@jtpio jtpio deleted the github-actions branch December 4, 2019 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants