Setting up testing #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maartenbreddels
force-pushed
the
testing
branch
from
ca2be0b
to
a1a23d5
Compare
|
Note: this needs a rebase. |
maartenbreddels
force-pushed
the
testing
branch
from
2a92477
to
83f7bcc
Compare
|
It passes, but requires pytest<4, which is not ideal, at least it provides us with a small safety net for now. |
This was referenced Jan 29, 2019
Closed
|
@maartenbreddels @SylvainCorlay i'd like to set up a linter for #57 and #58, is it possible to merge this PR? |
Closed
maartenbreddels
force-pushed
the
testing
branch
from
0e70904
to
dbb3866
Compare
maartenbreddels
force-pushed
the
testing
branch
from
dbb3866
to
e2df17f
Compare
|
Woot! |
|
@timkpaine I'll rebase your PRs, thanks for helping out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This already exposes a bug, voila does not like absolute paths. Good start to setup travis around this.