Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use asyncio to execute cells #374

Conversation

maartenbreddels
Copy link
Member

This allows concurrent requests, instead of blocking requests when cells are executed

@maartenbreddels maartenbreddels force-pushed the feat_asynio_cell_execution branch from 6ae913b to d773a96 Compare August 30, 2019 13:17
@jtpio
Copy link
Member

jtpio commented Aug 30, 2019

This already looks much nicer with async / await.

Note: this drops support for Python 2? (:tada:)

@maartenbreddels
Copy link
Member Author

Yes, I should change .travis.yml. But how do we test py35? conda-forge doesn't do that anymore right? We'd have to test that using pip?

This allows concurrent requests, instead of blocking requests when cells are executed
@maartenbreddels
Copy link
Member Author

This PR is needed for the asyncio jupyter client: jupyter/jupyter_client#471

And there are issues with connecting to the kernel, and widgets do not seem to work.

@SylvainCorlay
Copy link
Member

Closing as superseeded by several PRs by @maartenbreddels and @davidbrochart.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants