Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows CI #1443

Merged
merged 2 commits into from
Feb 7, 2024
Merged

Fix Windows CI #1443

merged 2 commits into from
Feb 7, 2024

Conversation

trungleduc
Copy link
Member

@trungleduc trungleduc commented Feb 7, 2024

References

Fixes the issue found here https://github.com/voila-dashboards/voila/actions/runs/7789487059/job/21241223631?pr=1442#step:5:337

Code changes

User-facing changes

Backwards-incompatible changes

Copy link
Contributor

github-actions bot commented Feb 7, 2024

Binder 👈 Launch a Binder on branch trungleduc/voila/fix-win-ci

Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou
Copy link
Member

I believe I've seen the same in JupyterCad

@martinRenou martinRenou merged commit 5aa861d into voila-dashboards:main Feb 7, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants