Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not clean up kernel resources after execution #1334

Merged
merged 2 commits into from
Jun 28, 2023
Merged

Do not clean up kernel resources after execution #1334

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
54d268d
Do not clean up resources after execution
martinRenou Jun 22, 2023
096e25f
Only clean the kernel client
martinRenou Jun 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion voila/notebook_renderer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,6 @@ async def _jinja_cell_generator(self, nb, kernel_id):
await self._cleanup_resources()

async def _cleanup_resources(self):
await ensure_async(self.executor.km.cleanup_resources())
await ensure_async(self.executor.kc.stop_channels())

async def load_notebook(self, path):
Expand Down