-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automatically download labvariables CSS instead of shipping them #1062
Automatically download labvariables CSS instead of shipping them #1062
Conversation
Benchmark reportThe execution time (in milliseconds) are grouped by test file, test type and browser. Results table
❗ Test metadata have changed--- /dev/fd/63 2022-01-18 14:41:00.313419431 +0000
+++ /dev/fd/62 2022-01-18 14:41:00.313419431 +0000
@@ -4,37 +4,37 @@
"BENCHMARK_REFERENCE": "actual"
},
"browsers": {
- "chromium": "97.0.4666.0"
+ "chromium": "94.0.4595.0"
},
"systemInformation": {
"cpu": {
- "brand": "Xeon® E5-2673 v4",
+ "brand": "Xeon® E5-2673 v3",
"cache": {
"l1d": 65536,
"l1i": 65536,
"l2": 524288,
- "l3": 52428800
+ "l3": 31457280
},
"cores": 2,
"family": "6",
- "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm 3dnowprefetch invpcid_single pti fsgsbase bmi1 hle avx2 smep bmi2 erms invpcid rtm rdseed adx smap xsaveopt md_clear",
+ "flags": "fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush mmx fxsr sse sse2 ss ht syscall nx pdpe1gb rdtscp lm constant_tsc rep_good nopl xtopology cpuid pni pclmulqdq ssse3 fma cx16 pcid sse4_1 sse4_2 movbe popcnt aes xsave avx f16c rdrand hypervisor lahf_lm abm invpcid_single pti fsgsbase bmi1 avx2 smep bmi2 erms invpcid xsaveopt md_clear",
"governor": "",
"manufacturer": "Intel®",
- "model": "79",
+ "model": "63",
"physicalCores": 2,
"processors": 1,
"revision": "",
"socket": "",
- "speed": 2.3,
+ "speed": 2.4,
"speedMax": null,
"speedMin": null,
- "stepping": "1",
+ "stepping": "2",
"vendor": "GenuineIntel",
"virtualization": false,
"voltage": ""
},
"mem": {
- "total": 7289610240
+ "total": 7291699200
},
"osInfo": {
"arch": "x64",
@@ -42,11 +42,11 @@
"codename": "Focal Fossa",
"codepage": "UTF-8",
"distro": "Ubuntu",
- "kernel": "5.11.0-1025-azure",
+ "kernel": "5.8.0-1040-azure",
"logofile": "ubuntu",
"platform": "linux",
"release": "20.04.3 LTS",
- "serial": "bfb5cc16a13d479a868c817b847bcf8f",
+ "serial": "cfc067bfcb844f35865e279a1b0e66c5",
"servicepack": "",
"uefi": false
} |
13c0905
to
62083ba
Compare
I don't get the UI test failure. It looks like a font-size difference but the font-size has not been changed using this PR. This CSS variables are still properly discovered by the reveal template. I will update the reference screenshots. |
62083ba
to
83e6f60
Compare
|
I am not sure this is a use-case we actually support right now? Those users would also need to install nbconvert in some way, and nbconvert does the same as this PR proposes. (EDIT: this is not true, see #1062 (comment))
Another idea could be to include those CSS files in the |
No I think you had a point. This CSS, not being in the sdist, will not be part of the |
I looked at |
With this PR in voila, it's not included in the It's not included in the |
Can we update |
Yes, we can do that. I wonder if that could be considered bad practice? |
1b539d4
to
03e5429
Compare
I don't know, but we had the same pattern for ignoring |
Ok, thanks :) I updated my PR |
1ffd800
to
fa5a79b
Compare
I accidentally canceled the CI, retriggering it |
fa5a79b
to
235aed2
Compare
Thanks @martinRenou ! |
Remove
labvariables.css
andmaterialcolors.css
files from the repo. Instead we download them automatically, similar to what nbconvert does: https://github.com/jupyter/nbconvert/blob/main/setup.pyCode changes
Automatically download CSS files on install
User-facing changes
None
Backwards-incompatible changes
None