Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lab template: fix body tag #1053

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Lab template: fix body tag #1053

merged 1 commit into from
Jan 12, 2022

Conversation

martinRenou
Copy link
Member

References

In combination with jupyter/nbconvert#1704, it fixes an issue where the background for Matplotlib figures is not correct.

Code changes

Change the body tag to add the missing data-jp-theme-light and data-jp-theme-name properties.

User-facing changes

Before

before

After

after

Backwards-incompatible changes

None

@github-actions
Copy link
Contributor

Binder 👈 Launch a Binder on branch martinRenou/voila/template_fix_body

@martinRenou martinRenou added the enhancement New feature or request label Jan 12, 2022
@trungleduc
Copy link
Member

Thanks @martinRenou!

@trungleduc trungleduc added the bug Something isn't working label Jan 12, 2022
@trungleduc trungleduc merged commit 2ab11c8 into voila-dashboards:main Jan 12, 2022
@martinRenou martinRenou deleted the template_fix_body branch January 12, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trungleduc trungleduc trungleduc approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinRenou @trungleduc