Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass version spec as a GitHub Actions input #1007

Merged
merged 1 commit into from
Oct 20, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Oct 20, 2021

References

Similar change as in JupyterLab: jupyterlab/jupyterlab#11322

To take into account the latest changes in Jupyter Releaser.

Code changes

CI fix

User-facing changes

None

Backwards-incompatible changes

None

@jtpio jtpio added this to the 0.2.x milestone Oct 20, 2021
@github-actions
Copy link
Contributor

Binder 👈 Try it on binder (branch jtpio/voila/check-release-spec)

@jtpio
Copy link
Member Author

jtpio commented Oct 20, 2021

This can be backported to 0.2.x

@trungleduc
Copy link
Member

Failed tests are not related.

@trungleduc
Copy link
Member

Thank @jtpio!

@trungleduc trungleduc merged commit 492a4a3 into voila-dashboards:main Oct 20, 2021
@jtpio jtpio deleted the check-release-spec branch October 21, 2021 06:31
@jtpio
Copy link
Member Author

jtpio commented Oct 21, 2021

@meeseeksdev please backport to 0.2.x

meeseeksmachine pushed a commit to meeseeksmachine/voila that referenced this pull request Oct 21, 2021
jtpio added a commit that referenced this pull request Oct 21, 2021
…7-on-0.2.x

Backport PR #1007 on branch 0.2.x (Pass version spec as a GitHub Actions input)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants