Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Execution timeout change #742

Closed
jeffyjefflabs opened this issue Oct 20, 2020 · 2 comments · Fixed by #797
Closed

Execution timeout change #742

jeffyjefflabs opened this issue Oct 20, 2020 · 2 comments · Fixed by #797
Labels
documentation

Comments

@jeffyjefflabs
Copy link
Contributor

I just noticed the default cell execution timeout changed from 30s in 0.1 to None in 0.2. I realize this is inherited from upstream (jupyter/nbconvert#791) and that I can set a timeout myself, but I thought it might be worth mentioning here. From a UX perspective, at some point the user will get tired of watching the "Executing" spinner and wonder if something is wrong. So, does it make sense for Voila to set its own default? If no, that's fine (as discussed in the nbconvert thread, the "right" number might be different for everyone), but maybe it's worth calling attention to the configuration setting in the docs.
@jtpio
Copy link
Member

jtpio commented Dec 22, 2020

Thanks @jeffyjefflabs.

Do you think this should be in the user documentation? There could be a small section to cover this.

If so, would you like to open a PR? Thanks!

jeffyjefflabs added a commit to jeffyjefflabs/voila that referenced this issue Jan 7, 2021
@jeffyjefflabs
Describe cell execution timeout in docs
841f6dc 
Voila inherits this setting from nbconvert, and the default is no timeout.  This may be undesirable UX in a dashboard, since the user has no indication of whether something has gone wrong or if they just need to keep waiting longer for the notebook to execute and render.  Fixes voila-dashboards#742.
@jeffyjefflabs jeffyjefflabs mentioned this issue Jan 7, 2021
Merged
@jeffyjefflabs
Copy link
Contributor Author

Sure - I opened #797. It seemed to fit best on the "Customizing Voila" page, but feel free to move it elsewhere.

@jtpio jtpio closed this as completed in #797 Jan 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Describe cell execution timeout in docs jeffyjefflabs/voila
2 participants
@jtpio @jeffyjefflabs