Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add releaser config #148

Merged
merged 1 commit into from
Nov 2, 2021
Merged

Add releaser config #148

merged 1 commit into from
Nov 2, 2021

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 21, 2021

Fixes #147

TODO

  • Add the Releaser config
  • Bump version script to update the Python package and npm packages

@jtpio jtpio closed this Sep 21, 2021
@jtpio jtpio reopened this Sep 21, 2021
@hbcarlos
Copy link
Member

Maybe we should change the default branch to main.

@jtpio
Copy link
Member Author

jtpio commented Sep 21, 2021

Maybe we should change the default branch to main.

Sounds good 👍

@jtpio jtpio closed this Sep 21, 2021
@jtpio jtpio reopened this Sep 21, 2021
@jtpio
Copy link
Member Author

jtpio commented Nov 2, 2021

For the bump version script maybe we can keep it simple and have something that takes the version as is and sets the same for both the Python package and the JS packages.

Instead of having the patch / minor / major flow of going through alpha -> beta -> rc -> final.

@hbcarlos
Copy link
Member

hbcarlos commented Nov 2, 2021

Thanks for working on this Jeremy.

@jtpio
Copy link
Member Author

jtpio commented Nov 2, 2021

CI is green now.

@hbcarlos
Copy link
Member

hbcarlos commented Nov 2, 2021

Is it ready?
I can take a look and merge tonight.

@jtpio
Copy link
Member Author

jtpio commented Nov 2, 2021

For bumping the version with the releaser we can use two options with the current bump-version.py script:

  • next:
    • to increment a patch release, for example from 0.2.0 to 0.2.1
    • to increment a pre-release, for example from 0.3.0a0 to 0.3.0a1
  • a version directly
    • for example we are currently on 0.2.0 and we can pass 0.3.0a0 directly for the next pre-release,

JS packages are formatted based on the Python version.

@jtpio
Copy link
Member Author

jtpio commented Nov 2, 2021

Is it ready?

I think so. I wanted to do the branch rename to main first but don't have access to that section in the settings:

image

@jtpio
Copy link
Member Author

jtpio commented Nov 2, 2021

Also we need to create a PyPI token for voila-gridstack and add it to the PYPI_TOKEN_MAP: https://jupyter-releaser.readthedocs.io/en/latest/how_to_guides/convert_repo.html#checklist-for-adoption

@jtpio jtpio marked this pull request as ready for review November 2, 2021 17:42
@jtpio
Copy link
Member Author

jtpio commented Nov 2, 2021

Binder link to do a quick smoke test: https://mybinder.org/v2/gh/jtpio/voila-gridstack/releaser?urlpath=lab

@jtpio jtpio mentioned this pull request Nov 2, 2021
5 tasks
@hbcarlos
Copy link
Member

hbcarlos commented Nov 2, 2021

Wow! Thank you so much!
We can rename the branch tomorrow in another PR.

@hbcarlos hbcarlos merged commit 8f18c00 into voila-dashboards:master Nov 2, 2021
@jtpio jtpio deleted the releaser branch November 3, 2021 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adopt the Jupyter Releaser for automated releases
2 participants