Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change launch button #114

Merged
merged 1 commit into from
Mar 25, 2021
Merged

Change launch button #114

merged 1 commit into from
Mar 25, 2021

Conversation

hbcarlos
Copy link
Member

Solves #84

Changed the icon and tooltip in the notebook toolbar and editor toolbar for consistency.
Now both open Voilà with the gridstack template.

I'm open to discussion about with icon to use.

notebook-button

editor-button

@fcollonval
Copy link
Contributor

LGTM

Copy link
Member

@jtpio jtpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@jtpio jtpio merged commit 9879049 into master Mar 25, 2021
@jtpio jtpio deleted the voila_button branch March 25, 2021 19:37
@jtpio jtpio added the jupyterlab-extension The Voila Gridstack extension for JupyterLab label Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
jupyterlab-extension The Voila Gridstack extension for JupyterLab
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants