Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve drag & drop from notebook #100

Merged
merged 5 commits into from
Mar 24, 2021

Conversation

fcollonval
Copy link
Contributor

@fcollonval fcollonval commented Mar 23, 2021

This PR fixes partly #87:

  • When dropping a cell from a notebook, the widget size is set according to the cell size
  • Add button to compact the grid on the top left corner
  • Add helper text when there are no widgets in the editor
  • Block dragging early - don't wait for the drop to tell the user a cell is not a valid source.

Failed to insert a virtual widget to help placing the cell when drag & dropping it from the notebook

@fcollonval fcollonval marked this pull request as ready for review March 23, 2021 15:43
@hbcarlos
Copy link
Member

Thanks, looks great!

@hbcarlos hbcarlos merged commit 3e78fe6 into voila-dashboards:master Mar 24, 2021
@hbcarlos
Copy link
Member

Btw, did you try to update to gridstack v4.0.1 here? What happens, is not working fine?

@fcollonval
Copy link
Contributor Author

Did you try to update to gridstack v4.0.1 here? What happens, is not working fine?

From my tests, I did not encounter troubles - but I wanted to focus on one feature by PR (what I don't do enough 😉 ).

@hbcarlos
Copy link
Member

No! I really appreciate these PRs, this is a huge improvement!

This was referenced Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants