Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add instruction upload functionality to SAM #63

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add instruction upload functionality to SAM #63

merged 2 commits into from
Apr 19, 2024

Conversation

codingjoe
Copy link
Member

No description provided.

@codingjoe codingjoe self-assigned this Apr 19, 2024
@codingjoe codingjoe requested a review from amureki April 19, 2024 13:58
Copy link

codecov bot commented Apr 19, 2024

Codecov Report

Attention: Patch coverage is 94.11765% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 67.74%. Comparing base (9d177a6) to head (357d0db).
Report is 1 commits behind head on main.

Files Patch % Lines
sam/__main__.py 90.90% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #63      +/-   ##
==========================================
+ Coverage   60.61%   67.74%   +7.12%     
==========================================
  Files          11       11              
  Lines         424      465      +41     
==========================================
+ Hits          257      315      +58     
+ Misses        167      150      -17     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit of documentation on how to use this could be helpful, otherwise looks fine to me.

sam/config.py Outdated Show resolved Hide resolved
@codingjoe codingjoe requested a review from amureki April 19, 2024 14:57
@codingjoe codingjoe merged commit e6dcbde into main Apr 19, 2024
7 checks passed
@codingjoe codingjoe deleted the upload branch April 19, 2024 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants