Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force Sam to perform a file search, if a user uploads a file #50

Merged
merged 6 commits into from
Apr 20, 2024

Conversation

codingjoe
Copy link
Member

No description provided.

@codingjoe codingjoe self-assigned this Apr 18, 2024
@codingjoe codingjoe requested a review from amureki April 18, 2024 08:11
@codingjoe codingjoe changed the title Force Sam to performa a file search, if a user uploads a file Force Sam to perform a file search, if a user uploads a file Apr 18, 2024
Copy link

codecov bot commented Apr 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.77%. Comparing base (512628b) to head (a1034ff).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #50      +/-   ##
==========================================
+ Coverage   82.97%   85.77%   +2.80%     
==========================================
  Files          11       11              
  Lines         505      506       +1     
==========================================
+ Hits          419      434      +15     
+ Misses         86       72      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@amureki amureki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about migrating from file_ids?
This is broken right now due to the new API:

https://voiio.sentry.io/issues/5216070581/

https://platform.openai.com/docs/assistants/migration/what-has-changed

@codingjoe codingjoe merged commit 4f99140 into main Apr 20, 2024
8 checks passed
@codingjoe codingjoe deleted the file_search branch April 20, 2024 14:28
Copy link

sentry-io bot commented Apr 21, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ BadRequestError: Error code: 400 - {'error': {'message': "Invalid type for 'tools[0]': expected an object, but got... sam.bot in execute_run View Issue
  • ‼️ BadRequestError: Error code: 400 - {'error': {'message': 'Files with extensions [.png] are not supported for retri... sam.bot in add_message View Issue
  • ‼️ RuntimeError: coroutine ignored GeneratorExit sam.slack in handle_message View Issue
  • ‼️ BadRequestError: Error code: 400 - {'error': {'message': 'Invalid file format. Supported formats: "c", "cpp", "css... sam.bot in add_message View Issue
  • ‼️ ConnectionError: Connection closed by server. sam.slack in send_response View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants