Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 Race condition between message submission and runs #11

Closed
codingjoe opened this issue Dec 7, 2023 · 0 comments · Fixed by #18
Closed

🐛 Race condition between message submission and runs #11

codingjoe opened this issue Dec 7, 2023 · 0 comments · Fixed by #18
Labels
bug Something isn't working

Comments

@codingjoe
Copy link
Member

codingjoe commented Dec 7, 2023

Error description

The order of events is not fixed, and slow message processing can result in the message not being added to a thread after the run as harded.

How to reproduce

You can add a voice message to a channel and @-mention Sam.

Technical Notes

The processing of a mention, needs to hold until the message has been processed. A lock, based on the message Slack message ID would resolve this issue. Redis, which we already use implements a lock.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant