1, core-services: migrate towards core-services #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based 100% on the work by @sbromberger I didn't want the work to die. After this change, folks using lxd or incus containers will be able to create their own lower-priority core service to modify the permissions on the files to enable proper shutdown/reboot of the containers. These core services will survive upgrades to void-runit, unlike the current approach in the container script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based 100% on the work by @sbromberger
#113
I didn't want the work to die.
After this change, folks using lxd or incus containers will be able to create their own lower-priority core service to modify the permissions on the files to enable proper shutdown/reboot of the containers. These core services will survive upgrades to void-runit, unlike the current approach in the container script.