Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

containerd: update to 2.0.1. #53349

Merged
merged 1 commit into from
Dec 25, 2024
Merged

containerd: update to 2.0.1. #53349

merged 1 commit into from
Dec 25, 2024

Conversation

tsndqst
Copy link
Contributor

@tsndqst tsndqst commented Dec 4, 2024 •
edited
Loading

Testing the changes

  • I tested the changes in this PR: YES

Local build testing

  • I built this PR locally for my native architecture, (x86_64-glibc)
  • I built this PR locally for these architectures (if supported. mark crossbuilds):
    • aarch64

@tsndqst tsndqst mentioned this pull request Dec 4, 2024
Open
@tsndqst
Copy link
Contributor Author

tsndqst commented Dec 4, 2024

I need some help with generating the man pages when cross compiling.

@tsndqst tsndqst marked this pull request as draft December 4, 2024 15:47
@tsndqst tsndqst force-pushed the containerd-2 branch 5 times, most recently from d4306e4 to d03b782 Compare December 6, 2024 14:25
@tsndqst tsndqst marked this pull request as ready for review December 6, 2024 14:39
@tsndqst
Copy link
Contributor Author

tsndqst commented Dec 6, 2024

I found a way to get go to compile the man pages natively. There may be a better way to do it.

classabbyamp
classabbyamp reviewed Dec 24, 2024
View reviewed changes
srcpkgs/containerd/patches/skip_tests.patch Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can skip tests with make_check_args="-skip TestName"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Skipping tests this way doesn't seem to work for this package.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, I was overriding do_check. I'll try again with the normal do_check function.

classabbyamp
classabbyamp reviewed Dec 24, 2024
View reviewed changes
srcpkgs/containerd/template Show resolved Hide resolved
srcpkgs/containerd/template Outdated Show resolved Hide resolved
@tsndqst tsndqst changed the title containerd: update to 2.0.0. containerd: update to 2.0.1. Dec 24, 2024
@tsndqst tsndqst force-pushed the containerd-2 branch 12 times, most recently from 368876a to 32d7d75 Compare December 25, 2024 14:57
@classabbyamp classabbyamp merged commit 6d5a2ac into void-linux:master Dec 25, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@classabbyamp classabbyamp classabbyamp left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tsndqst @classabbyamp