julia: update to 1.0.1. #3242
Closed
julia: update to 1.0.1. #3242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
non-Jedi
force-pushed
the
julia1.0.0-internal-llvm
branch
from
2076a8e to
f6bcc9a
Compare
|
CI times out, but locally I haven't seen a problem with this. |
non-Jedi
force-pushed
the
julia1.0.0-internal-llvm
branch
from
f6bcc9a to
631850a
Compare
|
1.0.1 was released in last couple days, so updating to that instead of 1.0.0. |
non-Jedi
force-pushed
the
julia1.0.0-internal-llvm
branch
3 times, most recently
from
384e4c8 to
627fa8f
Compare
|
and should probably ping the maintainer: @espectalll |
|
To ease the review process (and because there are changes in this PR compared to
|
|
I'll take a look as soon as possible, I had this pending for weeks but sadly I have a hard time to properly address my own package. In particular, should look into why |
|
@espectalll I'd be happy to take on maintainership of this package if you'd like. The reason that |
non-Jedi
force-pushed
the
julia1.0.0-internal-llvm
branch
2 times, most recently
from
742fe79 to
cd34324
Compare
|
@espectalll ping? |
|
If you're pinging me asking to being the maintainer of the package, sure, it probably can't be worse than I'm already doing. If you're asking me to approve the branch, sorry to say I'm not responsible for merging PRs. |
|
As the maintainer, I thought you might want to review the branch before it was merged, which was my takeaway from your previous comment. If there's no desire to do so, and you're okay with me taking over maintainership, I'll push an update with myself as the maintainer and ping somebody with merge rights about this getting into master. :) Thanks. |
non-Jedi
force-pushed
the
julia1.0.0-internal-llvm
branch
from
cd34324 to
bcb26d0
Compare
|
Since it was requested in #voidlinux on freenode, for the record, and |
maxice8
reviewed
Nov 3, 2018
srcpkgs/julia/template
Outdated
| wrksrc=julia | ||
| # Falsely detects dependency on libllvm | ||
| noverifyrdeps=yes |
There was a problem hiding this comment.
maybe better to use skiprdeps=
|
ping |
[ci skip] Also packages dev files and docs separately. Maintainer changed to myself with current maintainers permission.
|
Sorry. Been disconnected for a bit. Trying to figure out exactly which file is creating the llvm dependency now. |
[ci skip] Also change packaging style from noverifyrdeps to skiprdeps.
non-Jedi
force-pushed
the
julia1.0.0-internal-llvm
branch
from
bcb26d0 to
c9c2db3
Compare
|
@maxice8 Rebased and pushed an additional commit with your recommended change and an update to 1.0.2. If it looks good to you, let me know, and I can squash the two and force push. |
|
LGTM, please squash |
|
Thanks |
|
musl build failed: https://build.voidlinux.org/builders/x86_64-musl_builder/builds/15140 Don't have access to a musl-based system or expertise in debugging these things. Should I PR a version bump with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a less controversial version of #2290. Rather than patching void-packages llvm6, this PR just lets Julia build its own internal LLVM. This is the approach that Arch and other distros I investigated are currently taking with Julia.
If the preference is to patch llvm 6, this still might not be a bad idea to merge for now until #2290 can be properly vetted.