Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

timeshift: fix compatibility with util-linux 2.37.1 #32329

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

jchook
Copy link
Contributor

@jchook jchook commented Aug 5, 2021

General

Have the results of the proposed changes been tested?

  • I use the packages affected by the proposed changes on a regular basis and confirm this PR works for me
  • I generally don't use the affected packages but briefly tested this PR

Timeshift is virtually unusable due to a change in util-linux, see:

This PR applies an official patch to make the package usable on Void until the next official release, presumably later this year.

@ericonr
Copy link
Member

ericonr commented Aug 5, 2021

The commit should be something like:

timeshift: fix compatibility with util-linux 2.37.1.

Timeshift will only start in "Live USB Mode".

Upstream issues:
https://github.com/teejee2008/timeshift/issues/425
https://github.com/teejee2008/timeshift/issues/753
https://github.com/teejee2008/timeshift/issues/755

And the commit needs to increase revision of the timeshift template, otherwise it won't be rebuilt and changes won't be picked up.

@jchook jchook changed the title timeshift - fix for #425, #753, #755 timeshift - fix compatibility with util-linux 2.37.1 Aug 5, 2021
@jchook
Copy link
Contributor Author

jchook commented Aug 5, 2021

Thank you! I bumped the revision and added your suggested commit message (much better, thanks).

@paper42
Copy link
Member

paper42 commented Aug 5, 2021

@jchook GitHub shows Ghost as the commit author, do you know why it is this way? Maybe you don't have the email used in the commit set in your GitHub settings?

@jchook
Copy link
Contributor Author

jchook commented Aug 5, 2021

@paper42 Yep that was the issue. Updated.

@jchook jchook changed the title timeshift - fix compatibility with util-linux 2.37.1 timeshift: fix compatibility with util-linux 2.37.1 Aug 5, 2021
@ericonr ericonr merged commit 38ecf6a into void-linux:master Aug 6, 2021
@ericonr
Copy link
Member

ericonr commented Aug 6, 2021

Thanks!

@jchook jchook deleted the timeshift branch August 6, 2021 03:15
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants